From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: lionel.debieve@st.com, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org, bigeasy@linutronix.de,
Patrice Chotard <patrice.chotard@st.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware
Date: Tue, 21 Mar 2017 16:15:33 -0400 [thread overview]
Message-ID: <20170321161533.44c4df87@vmware.local.home> (raw)
In-Reply-To: <alpine.DEB.2.20.1703211950040.3776@nanos>
On Tue, 21 Mar 2017 19:51:47 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> On Tue, 21 Mar 2017, Steven Rostedt wrote:
> > > /*
> > > * Disable interrupts so we don't get the IRQ line
> > > bouncing
> >
> > I'm nervous about the above comment, which in full is:
> >
> > /*
> > * Disable interrupts so we don't get the IRQ line bouncing
> > * up and down while interrupts are disabled.
> > */
> >
> > I'm not sure if disabling interrupts helps on an SMP system. This
> > patch does change what happens when port->sysrq is set. But I'm not
> > sure we care.
>
> It disables interrupts at the device level which obviously helps
> whether on SMP or not.
>
OK, so this has nothing to do with the local_irq_save() that is being
removed, which would be fine then.
-- Steve
next prev parent reply other threads:[~2017-03-21 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 16:05 [PATCH RT] tty: serial: st-asc: Make the locking RT aware lionel.debieve
2017-03-21 18:44 ` Steven Rostedt
2017-03-21 18:51 ` Thomas Gleixner
2017-03-21 20:15 ` Steven Rostedt [this message]
2017-03-22 8:43 ` Lionel DEBIEVE
2017-03-22 16:10 ` Steven Rostedt
2017-03-22 16:14 ` Lionel DEBIEVE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321161533.44c4df87@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=lionel.debieve@st.com \
--cc=patrice.chotard@st.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox