From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933956AbdCVA44 (ORCPT ); Tue, 21 Mar 2017 20:56:56 -0400 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:54711 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932903AbdCVA4z (ORCPT ); Tue, 21 Mar 2017 20:56:55 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2859:2897:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4362:5007:6261:7576:7875:8599:9025:9040:10004:10400:10848:10913:10967:11026:11232:11473:11658:11914:12043:12438:12555:12740:12760:12783:12895:12986:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:14849:21080:21434:21451:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: roll80_1e505e0adb860 X-Filterd-Recvd-Size: 2184 Date: Tue, 21 Mar 2017 17:56:43 -0700 From: Steven Rostedt To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Masami Hiramatsu , "H. Peter Anvin" , Andy Lutomirski , Linus Torvalds Subject: Re: [PATCH 6/6 v3] ftrace/x86: Use Makefile logic instead of #ifdef of compling ftrace_*.o Message-ID: <20170321175455.629b94ee@vmware.local.home> In-Reply-To: <20170320140425.oirnr2oce4d2qlcw@treble> References: <20170318210923.814509382@goodmis.org> <20170318211149.740427022@goodmis.org> <20170320140425.oirnr2oce4d2qlcw@treble> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Mar 2017 09:04:25 -0500 Josh Poimboeuf wrote: > On Sat, Mar 18, 2017 at 05:09:29PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > Currently ftrace_32.S and ftrace_64.S are compiled even when > > CONFIG_FUNCTION_TRACER is not set. This means there's an > > unnecessary #ifdef to protect the code. Instead of using > > preprocessor directives, only compile those files when > > FUNCTION_TRACER is defined. > > > > Link: > > http://lkml.kernel.org/r/20170316210043.peycxdxktwwn6cid@treble > > Suggested-by: Josh Poimboeuf Signed-off-by: > > Steven Rostedt (VMware) > > The subject has a typo ("compling") and would parse better if the > second "of" where changed to a "for": "for compiling". Otherwise: But this was to comply with #ifdef of ftrace_*.o! ;-) > > Reviewed-by: Josh Poimboeuf > Thanks! -- Steve