From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758773AbdCVGEJ (ORCPT ); Wed, 22 Mar 2017 02:04:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52636 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbdCVGEA (ORCPT ); Wed, 22 Mar 2017 02:04:00 -0400 Date: Wed, 22 Mar 2017 07:01:38 +0100 From: Greg Kroah-Hartman To: Arushi Singhal Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Teddy Wang , linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: Re: staging: iio: Replace a bit shift by a use of BIT. Message-ID: <20170322060138.GA13416@kroah.com> References: <20170322024942.GA21242@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322024942.GA21242@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 08:19:42AM +0530, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- > drivers/staging/iio/adc/ad7816.c | 2 +- > drivers/staging/iio/cdc/ad7150.c | 2 +- > drivers/staging/iio/cdc/ad7746.c | 22 +++++++++++----------- > 3 files changed, 13 insertions(+), 13 deletions(-) Please be careful about your cc: list, you missed the correct list, and added one not needed at all. And you forgot the [PATCH] prefix :( thanks, greg k-h