From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934080AbdCVJlp (ORCPT ); Wed, 22 Mar 2017 05:41:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49918 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932757AbdCVJlj (ORCPT ); Wed, 22 Mar 2017 05:41:39 -0400 Date: Wed, 22 Mar 2017 12:41:14 +0300 From: Dan Carpenter To: Arushi Singhal Cc: outreachy-kernel@googlegroups.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Teddy Wang , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: Re: staging: iio: Replace a bit shift by a use of BIT. Message-ID: <20170322094114.GH32449@mwanda> References: <20170322024942.GA21242@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322024942.GA21242@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 08:19:42AM +0530, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- > drivers/staging/iio/adc/ad7816.c | 2 +- > drivers/staging/iio/cdc/ad7150.c | 2 +- > drivers/staging/iio/cdc/ad7746.c | 22 +++++++++++----------- > 3 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c > index 17d280581e24..42f637ca0251 100644 > --- a/drivers/staging/iio/adc/ad7816.c > +++ b/drivers/staging/iio/adc/ad7816.c > @@ -222,7 +222,7 @@ static ssize_t ad7816_show_value(struct device *dev, > value = (s8)((data >> AD7816_TEMP_FLOAT_OFFSET) - 103); > data &= AD7816_TEMP_FLOAT_MASK; > if (value < 0) > - data = (1 << AD7816_TEMP_FLOAT_OFFSET) - data; > + data = (BIT(AD7816_TEMP_FLOAT_OFFSET)) - data; Remove the extra parentheses from all of these: data = BIT(AD7816_TEMP_FLOAT_OFFSET) - data; regards, dan carpenter