From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965490AbdCVSOy (ORCPT ); Wed, 22 Mar 2017 14:14:54 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:33946 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965106AbdCVSOq (ORCPT ); Wed, 22 Mar 2017 14:14:46 -0400 Date: Wed, 22 Mar 2017 11:14:42 -0700 From: Brian Norris To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Caesar Wang , Doug Anderson , devicetree@vger.kernel.org, Rob Herring , Stephen Barber , linux-arm-kernel@lists.infradead.org, Chris Zhong , Dmitry Torokhov Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: add regulator info for Kevin digitizer Message-ID: <20170322181441.GC98450@google.com> References: <20170320235344.126298-1-briannorris@chromium.org> <20170320235344.126298-5-briannorris@chromium.org> <20415662.PctC9IM4SC@phil> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20415662.PctC9IM4SC@phil> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 09:26:41AM +0100, Heiko Stuebner wrote: > Am Montag, 20. März 2017, 16:53:44 CET schrieb Brian Norris: > > We need to enable this regulator before the digitizer can be used. Wacom > > recommended waiting for 100 ms before talking to the HID. > > > > Signed-off-by: Brian Norris > > --- > > v3: > > * reintroduced into patch set; bindings are in linux-next > > --- > > arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts > > b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts index > > 2f720cf2fd07..f4714c4606f3 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts > > @@ -232,6 +232,9 @@ ap_i2c_dig: &i2c2 { > > according to the hid-over-i2c binding, this should use a special compatible > like > > compatible = "wacom,w9013", "hid-over-i2c" > > As the binding patch is from Caesar, I assume that is the Kevin component and > I can add that myself, just need confirmation that this is actually the correct > component :-) . *Sigh.* The I2C (and SPI) framework is still broken w.r.t. multiple compatible strings and drivers built as modules [1]. So I'd really rather not do this... ...but yes, that's a fair component description. Brian [1] Some discussion about SPI: https://patchwork.kernel.org/patch/7630571/ And the discussion about I2C (25% through that thread): https://patchwork.kernel.org/patch/9455245/