From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935907AbdCVTAg (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Mar 2017 15:00:36 -0400
Received: from mga03.intel.com ([134.134.136.65]:46413 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S934477AbdCVTA1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Mar 2017 15:00:27 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,206,1486454400"; 
   d="scan'208";a="63769078"
Date: Wed, 22 Mar 2017 12:00:25 -0700
From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, linux-edac <linux-edac@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] RAS: Add a Corrected Errors Collector
Message-ID: <20170322190024.GA3073@intel.com>
References: <20170309100818.15466-1-bp@alien8.de>
 <20170309100818.15466-4-bp@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170309100818.15466-4-bp@alien8.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 09, 2017 at 11:08:17AM +0100, Borislav Petkov wrote:
> +static bool cec_add_mce(struct mce *m)
> +{
> +	if (!m)
> +		return false;
> +
> +	if (memory_error(m) && mce_usable_address(m))
> +		if (!cec_add_elem(m->addr >> PAGE_SHIFT))
> +			return true;
> +
> +	return false;
> +}

You also need to check that bit 61 of m->status is zero here.
The collector is hiding uncorrected errors too.

-Tony