public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Felipe Balbi <balbi@kernel.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
	Romain Perier <romain.perier@collabora.com>
Subject: Re: linux-next: manual merge of the usb tree with the usb-gadget-fixes tree
Date: Thu, 23 Mar 2017 07:43:37 +0100	[thread overview]
Message-ID: <20170323064337.GD22801@kroah.com> (raw)
In-Reply-To: <20170323131633.44445bd0@canb.auug.org.au>

On Thu, Mar 23, 2017 at 01:16:33PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next merge of the usb tree got a conflict in:
> 
>   drivers/usb/gadget/udc/pch_udc.c
> 
> between commit:
> 
>   1f459262b0e1 ("usb: gadget: udc: remove pointer dereference after free")
> 
> from the usb-gadget-fixes tree and commit:
> 
>   d293408ef303 ("usb: gadget: pch_udc: Replace PCI pool old API")
> 
> from the usb tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 
> diff --cc drivers/usb/gadget/udc/pch_udc.c
> index 8a365aad66fe,84dcbcd756f0..000000000000
> --- a/drivers/usb/gadget/udc/pch_udc.c
> +++ b/drivers/usb/gadget/udc/pch_udc.c
> @@@ -1522,7 -1522,8 +1522,7 @@@ static void pch_udc_free_dma_chain(stru
>   		/* do not free first desc., will be done by free for request */
>   		td = phys_to_virt(addr);
>   		addr2 = (dma_addr_t)td->next;
> - 		pci_pool_free(dev->data_requests, td, addr);
> + 		dma_pool_free(dev->data_requests, td, addr);
>  -		td->next = 0x00;
>   		addr = addr2;
>   	}
>   	req->chain_len = 1;

Looks good to me, thanks!

greg k-h

      reply	other threads:[~2017-03-23  7:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  2:16 linux-next: manual merge of the usb tree with the usb-gadget-fixes tree Stephen Rothwell
2017-03-23  6:43 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170323064337.GD22801@kroah.com \
    --to=greg@kroah.com \
    --cc=balbi@kernel.org \
    --cc=garsilva@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=romain.perier@collabora.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox