From: Steven Rostedt <rostedt@goodmis.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Peter Zijlstra <peterz@infradead.org>, <mingo@kernel.org>,
<linux-kernel@vger.kernel.org>, <juri.lelli@gmail.com>,
<kernel-team@lge.com>
Subject: Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
Date: Thu, 23 Mar 2017 07:08:24 -0700 [thread overview]
Message-ID: <20170323070824.5f0ead54@vmware.local.home> (raw)
In-Reply-To: <20170323103651.GQ11100@X58A-UD3R>
On Thu, 23 Mar 2017 19:36:51 +0900
Byungchul Park <byungchul.park@lge.com> wrote:
> On Thu, Mar 23, 2017 at 10:44:45AM +0100, Peter Zijlstra wrote:
> > On Thu, Mar 23, 2017 at 11:12:49AM +0900, Byungchul Park wrote:
> > > It would be better to avoid pushing tasks to other cpu within
> > > a SD_PREFER_SIBLING domain, instead, get more chances to check
> > > other siblings.
> >
> > Did you forget to post the rt equivalent to patch 1?
>
> No. Fortunately, rt currently works as patch 1 does.
I'm thinking that the rt and deadline search for lowest rq functions
should be merged as one.
What they are doing is looking for the rq with the lowest priority.
deadline currently doesn't care if it picks an rq with an rt task
running on it, even when there's an rq with no rt tasks that the dl task
can migrate to. The same goes with rt. It could place an RT task on an
rq running a deadline task without knowing the rt task wont be able to
run on that cpu immediately.
-- Steve
next prev parent reply other threads:[~2017-03-23 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 2:12 [PATCH v3 1/3] sched/deadline: Make find_later_rq() choose a closer cpu in topology Byungchul Park
2017-03-23 2:12 ` [PATCH v3 2/3] sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq() Byungchul Park
2017-03-23 2:12 ` [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Byungchul Park
2017-03-23 9:21 ` Byungchul Park
2017-03-23 13:59 ` Steven Rostedt
2017-03-23 9:44 ` Peter Zijlstra
2017-03-23 10:36 ` Byungchul Park
2017-03-23 14:08 ` Steven Rostedt [this message]
2017-03-23 22:45 ` Byungchul Park
2017-03-27 14:33 ` [PATCH v3 1/3] sched/deadline: Make find_later_rq() choose a closer cpu in topology Juri Lelli
2017-03-28 0:04 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323070824.5f0ead54@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=byungchul.park@lge.com \
--cc=juri.lelli@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox