From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754650AbdCWJde (ORCPT ); Thu, 23 Mar 2017 05:33:34 -0400 Received: from userp1050.oracle.com ([156.151.31.82]:47490 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbdCWJdb (ORCPT ); Thu, 23 Mar 2017 05:33:31 -0400 Date: Thu, 23 Mar 2017 12:31:46 +0300 From: Dan Carpenter To: Arushi Singhal Cc: lars@metafoo.de, devel@driverdev.osuosl.org, Michael Hennerich , linux-iio@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, Peter Meerwald-Stadler , Hartmut Knaack , Jonathan Cameron Subject: Re: [PATCH v2] staging: iio: Replace a bit shift by a use of BIT. Message-ID: <20170323093146.GM32449@mwanda> References: <20170322164234.GA18805@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322164234.GA18805@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 10:12:34PM +0530, Arushi Singhal wrote: > /* Capacitive Channel Setup Register Bit Designations (AD7746_REG_CAP_SETUP) */ > -#define AD7746_CAPSETUP_CAPEN (1 << 7) > -#define AD7746_CAPSETUP_CIN2 (1 << 6) /* AD7746 only */ > -#define AD7746_CAPSETUP_CAPDIFF (1 << 5) > -#define AD7746_CAPSETUP_CACHOP (1 << 0) > +#define AD7746_CAPSETUP_CAPEN (BIT(7)) > +#define AD7746_CAPSETUP_CIN2 (BIT(6)) /* AD7746 only */ > +#define AD7746_CAPSETUP_CAPDIFF (BIT(5)) > +#define AD7746_CAPSETUP_CACHOP (BIT(0)) Extra parens. regards, dan carpenter