From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Ankur Arora <ankur.a.arora@oracle.com>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen
Date: Thu, 23 Mar 2017 14:12:52 +0100 [thread overview]
Message-ID: <20170323131252.GA6008@redhat.com> (raw)
In-Reply-To: <a1f0404e-899e-8d56-ef65-858dacecb62d@oracle.com>
On Wed, Mar 22, 2017 at 10:56:02AM -0700, Ankur Arora wrote:
> >It is ok to do upload_pm_data() with delay i.e. after some other
> >resume actions are done and possibly xen-acpi-processor is in
> >running state ?
> The state uploaded is ACPI P and C state from struct acpi_processor
> which AFAICS is stable once inited so a delay would not lead to
> invalid state.
> The only concern would be the ACPI pCPU hotplug logic in
> acpi_processor_add() which could add a new entry in
> per_cpu(processors) but that also looks okay because either we
> get a NULL or we get a pointer to an inited structure.
>
> As for the hypervisor -- that falls back to more limited state after
> resume (because some of this state is thrown away at suspend) and so
> uses that until it gets the uploaded PM state from the initial-domain.
Patch looks good to me then.
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
next prev parent reply other threads:[~2017-03-23 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 22:43 [PATCH 0/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora
2017-03-21 22:43 ` [PATCH 1/2 v2] xen/acpi: Replace hard coded "ACPI0007" Ankur Arora
2017-03-21 22:43 ` [PATCH 2/2 v2] xen/acpi: upload PM state from init-domain to Xen Ankur Arora
2017-03-22 9:05 ` Stanislaw Gruszka
2017-03-22 17:56 ` Ankur Arora
2017-03-23 13:12 ` Stanislaw Gruszka [this message]
2017-03-23 16:45 ` [Xen-devel] [PATCH 0/2 " Boris Ostrovsky
2017-03-24 14:09 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323131252.GA6008@redhat.com \
--to=sgruszka@redhat.com \
--cc=ankur.a.arora@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).