From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755522AbdCWNSl (ORCPT ); Thu, 23 Mar 2017 09:18:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38280 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbdCWNSj (ORCPT ); Thu, 23 Mar 2017 09:18:39 -0400 Date: Thu, 23 Mar 2017 14:18:18 +0100 From: Greg KH To: Arushi Singhal Cc: w.d.hubbs@gmail.com, devel@driverdev.osuosl.org, kirk@reisers.ca, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, samuel.thibault@ens-lyon.org, chris@the-brannons.com Subject: Re: [PATCH 02/11] staging: speakup: Remove multiple assignments Message-ID: <20170323131818.GA21199@kroah.com> References: <20170321114235.1638-1-arushisinghal19971997@gmail.com> <20170321114235.1638-3-arushisinghal19971997@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321114235.1638-3-arushisinghal19971997@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 05:12:26PM +0530, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index f71206878363..f8fccc8bf6b2 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -270,9 +270,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos) > > static void speakup_date(struct vc_data *vc) > { > - spk_x = spk_cx = vc->vc_x; > - spk_y = spk_cy = vc->vc_y; > - spk_pos = spk_cp = vc->vc_pos; > + spk_x = vc->vc_x; > + spk_cx = spk_x; > + spk_y = vc->vc_y; > + spk_cy = spk_y; > + spk_pos = vc->vc_pos; > + spk_cp = spk_pos; Ick, this is harder to read now, don't you think? not good. greg k-h