* [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg
@ 2017-03-23 8:50 Pushkar Jambhlekar
2017-03-23 13:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-23 8:50 UTC (permalink / raw)
To: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
Cc: driverdev-devel, devel, linux-kernel, Pushkar Jambhlekar
Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant.
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f7e754e..cae0410 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1858,13 +1858,9 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
if (!bd || bd->magic != DGNC_BOARD_MAGIC)
return;
- dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
-
spin_lock_irqsave(&ch->ch_lock, flags);
bd->bd_ops->send_immediate_char(ch, c);
spin_unlock_irqrestore(&ch->ch_lock, flags);
-
- dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n");
}
/* Return modem signals to ld. */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg
2017-03-23 8:50 [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg Pushkar Jambhlekar
@ 2017-03-23 13:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-23 13:21 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Lidza Louina, Mark Hounschell, driverdev-devel, devel,
linux-kernel
On Thu, Mar 23, 2017 at 02:20:53PM +0530, Pushkar Jambhlekar wrote:
> Current implementation manually traces function using 'dev_dbg'. This way is not needed because of ftrace, making these calls redundant.
Always wrap your changelog lines properly.
Also, someone else sent this same patch in right before you did, sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 8:50 [PATCH] drivers/staging/dgnc: Removing manual function tracing using dev_dbg Pushkar Jambhlekar
2017-03-23 13:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox