* [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment
@ 2017-03-23 7:08 Zhengyi Shen
2017-03-23 13:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Zhengyi Shen @ 2017-03-23 7:08 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Greg Kroah-Hartman, devel, linux-kernel
Fix endian sparse warnings of incorrect type in assignment.
This patch changes type to the appropriate endian specific versions.
Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
---
drivers/staging/fbtft/fbtft-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index d868405..ffb9a3b 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fbtft-io.c
@@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
src++;
}
tmp |= ((*src & 0x0100) ? 1 : 0);
- *(u64 *)dst = cpu_to_be64(tmp);
+ *(__be64 *)dst = cpu_to_be64(tmp);
dst += 8;
*dst++ = (u8)(*src++ & 0x00FF);
added++;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment
2017-03-23 7:08 [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Zhengyi Shen
@ 2017-03-23 13:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-23 13:31 UTC (permalink / raw)
To: Zhengyi Shen; +Cc: Thomas Petazzoni, devel, linux-kernel
On Thu, Mar 23, 2017 at 03:08:38PM +0800, Zhengyi Shen wrote:
> Fix endian sparse warnings of incorrect type in assignment.
> This patch changes type to the appropriate endian specific versions.
>
>
> Signed-off-by: Zhengyi Shen <shenzhengyi@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
> index d868405..ffb9a3b 100644
> --- a/drivers/staging/fbtft/fbtft-io.c
> +++ b/drivers/staging/fbtft/fbtft-io.c
> @@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
> src++;
> }
> tmp |= ((*src & 0x0100) ? 1 : 0);
> - *(u64 *)dst = cpu_to_be64(tmp);
> + *(__be64 *)dst = cpu_to_be64(tmp);
Really? I need an ack from a maintainer of this code before I'll take
this mess...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 7:08 [PATCH] staging:fbtft/fbtft-io: Fix incorrect type in assignment Zhengyi Shen
2017-03-23 13:31 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox