From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbdCXNp3 (ORCPT ); Fri, 24 Mar 2017 09:45:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59008 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbdCXNpV (ORCPT ); Fri, 24 Mar 2017 09:45:21 -0400 Date: Fri, 24 Mar 2017 14:44:59 +0100 From: Greg Kroah-Hartman To: Arushi Singhal Cc: oleg.drokin@intel.com, Andreas Dilger , James Simmons , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: lustre: Remove redundant code Message-ID: <20170324134459.GA26275@kroah.com> References: <20170324113952.GA31427@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170324113952.GA31427@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote: > Remove the code which do not have any value. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/lustre/lnet/lnet/net_fault.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c b/drivers/staging/lustre/lnet/lnet/net_fault.c > index 18183cbb9859..b60261db9e67 100644 > --- a/drivers/staging/lustre/lnet/lnet/net_fault.c > +++ b/drivers/staging/lustre/lnet/lnet/net_fault.c > @@ -997,11 +997,6 @@ lnet_fault_ctl(int opc, struct libcfs_ioctl_data *data) > int > lnet_fault_init(void) > { > - BUILD_BUG_ON(LNET_PUT_BIT != 1 << LNET_MSG_PUT); > - BUILD_BUG_ON(LNET_ACK_BIT != 1 << LNET_MSG_ACK); > - BUILD_BUG_ON(LNET_GET_BIT != 1 << LNET_MSG_GET); > - BUILD_BUG_ON(LNET_REPLY_BIT != 1 << LNET_MSG_REPLY); Why does this not have any value? How are you ensuring that these requirements are now being met? thanks, greg k-h