From: Peter Zijlstra <peterz@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: locking/atomic: Introduce atomic_try_cmpxchg()
Date: Fri, 24 Mar 2017 21:46:15 +0100 [thread overview]
Message-ID: <20170324204615.GB5680@worktop> (raw)
In-Reply-To: <CA+55aFzxsGUesnq7mqyas=8ZK5fvPc0Zs_=OO3ttZ6Cb7Fbz-A@mail.gmail.com>
On Fri, Mar 24, 2017 at 12:08:32PM -0700, Linus Torvalds wrote:
> On Fri, Mar 24, 2017 at 10:23 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > I tried a few variants, but nothing really made it better.
>
> So I really hate how your thing has two return values, and fakes the
> second one using the pointer value.
Inspired by C11 I'm afraid..
> So how about we change the interface entirely, with the goal being
> both type safety and good code generation?
I certainly like it better, but so far I'm having trouble reproducing
your results. What compiler version are you on?
next prev parent reply other threads:[~2017-03-24 20:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 12:44 locking/atomic: Introduce atomic_try_cmpxchg() Dmitry Vyukov
2017-03-24 14:21 ` Peter Zijlstra
2017-03-24 14:23 ` Dmitry Vyukov
2017-03-24 16:41 ` Peter Zijlstra
2017-03-24 16:54 ` Andy Lutomirski
2017-03-24 17:23 ` Peter Zijlstra
2017-03-24 17:51 ` Dmitry Vyukov
2017-03-24 18:08 ` Peter Zijlstra
2017-03-24 18:13 ` Peter Zijlstra
2017-03-24 19:16 ` Andy Lutomirski
2017-03-24 19:20 ` Linus Torvalds
2017-03-24 19:27 ` Andy Lutomirski
2017-03-24 20:15 ` Peter Zijlstra
2017-03-24 20:14 ` Peter Zijlstra
2017-03-24 20:21 ` Andy Lutomirski
2017-03-24 18:16 ` Dmitry Vyukov
2017-03-24 18:00 ` Peter Zijlstra
2017-03-24 18:04 ` Peter Zijlstra
2017-03-24 18:45 ` Andy Lutomirski
2017-03-24 19:17 ` Linus Torvalds
2017-03-24 21:23 ` Peter Zijlstra
2017-03-25 7:51 ` Peter Zijlstra
2017-03-25 18:00 ` Linus Torvalds
2017-03-25 18:20 ` Peter Zijlstra
2017-03-25 18:28 ` Linus Torvalds
2017-03-25 18:34 ` Linus Torvalds
2017-03-25 21:13 ` Peter Zijlstra
2017-03-25 22:08 ` Linus Torvalds
2017-03-27 9:48 ` Peter Zijlstra
2017-03-24 20:22 ` Peter Zijlstra
2017-03-24 20:27 ` Andy Lutomirski
2017-03-24 21:07 ` Peter Zijlstra
2017-03-24 19:08 ` Linus Torvalds
2017-03-24 20:46 ` Peter Zijlstra [this message]
2017-03-24 20:58 ` Linus Torvalds
2017-03-27 12:16 ` Peter Zijlstra
2017-03-27 13:45 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324204615.GB5680@worktop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox