From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <andy.gross@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
David Brown <david.brown@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] firmware: qcom: scm: Expose download-mode control
Date: Sat, 25 Mar 2017 22:13:28 -0700 [thread overview]
Message-ID: <20170326051328.GD70446@Bjorns-MacBook-Pro-2.local> (raw)
In-Reply-To: <20170324150633.2s3o3kiecnoeo4qt@rob-hp-laptop>
On Fri 24 Mar 08:06 PDT 2017, Rob Herring wrote:
> On Fri, Mar 17, 2017 at 09:15:22PM -0700, Bjorn Andersson wrote:
[..]
> > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> > index 20f26fbce875..8467a181f22c 100644
> > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> > @@ -18,6 +18,7 @@ Required properties:
> > * Core, iface, and bus clocks required for "qcom,scm"
> > - clock-names: Must contain "core" for the core clock, "iface" for the interface
> > clock and "bus" for the bus clock per the requirements of the compatible.
> > +- qcom,dload-mode-addr: Specifies the address for the download mode magic (optional)
>
> Size? 1 cell, 2 cell(, red cell, blue cell) or follows #addr-cells?
>
I believe this implementation only applies to the 64-bit systems, but
it's probably better to make it follow (or at least claim that it
follows) #address-cells.
I can update the description to include this.
Regards,
Bjorn
next prev parent reply other threads:[~2017-03-26 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 4:15 [PATCH 1/3] firmware: qcom: scm: Expose secure IO service Bjorn Andersson
2017-03-18 4:15 ` [PATCH 2/3] firmware: qcom: scm: Expose download-mode control Bjorn Andersson
2017-03-24 15:06 ` Rob Herring
2017-03-26 5:13 ` Bjorn Andersson [this message]
2017-03-27 18:53 ` Rob Herring
2017-03-18 4:15 ` [PATCH 3/3] arm64: dts: qcom: msm8996: Specify dload address Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326051328.GD70446@Bjorns-MacBook-Pro-2.local \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox