From: Willy TARREAU <wtarreau@haproxy.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder
Date: Mon, 27 Mar 2017 10:11:11 +0200 [thread overview]
Message-ID: <20170327081111.GA28802@haproxy.com> (raw)
In-Reply-To: <CAMuHMdVN=gJLh79iUDng_V8HomVeeObi0gnCjRNKN1du5cjyNw@mail.gmail.com>
On Fri, Mar 24, 2017 at 04:19:43PM +0100, Geert Uytterhoeven wrote:
> Hi Andy,
>
> On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
> >> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
> >> <andriy.shevchenko@linux.intel.com> wrote:
> >> > It looks like panel.c belongs to auxdisplay subsystem.
> >> >
> >> > Move it to drivers/auxdisplay folder.
> >> > No functional changes intended.
> >>
> >> I didn't move it to drivers/auxdisplay/ because it not only provides
> >> auxdisplay functionality, but also keypad functionality.
> >
> > Yes, I have noticed this. But keypad functionality is optional while
> > panel is main one. I think you would agree on this.
>
> I don't care that much, though. Willy?
Well, as long as it continues to work, I don't really care either. The
only thing to keep in mind is that it can be difficult to split the
driver in two since in some cases it's possible to use the same lines
for keypad and lcd.
Willy
next prev parent reply other threads:[~2017-03-27 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 14:06 [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder Andy Shevchenko
2017-03-24 14:06 ` [PATCH v1 2/2] auxdisplay: Move arm-charlcd.c " Andy Shevchenko
2017-03-24 15:16 ` Linus Walleij
2017-03-24 14:19 ` [PATCH v1 1/2] auxdisplay: Move panel.c " Geert Uytterhoeven
2017-03-24 14:29 ` Andy Shevchenko
2017-03-24 15:19 ` Geert Uytterhoeven
2017-03-27 8:11 ` Willy TARREAU [this message]
2017-03-27 8:26 ` Geert Uytterhoeven
2017-03-27 9:01 ` Willy TARREAU
2017-03-30 11:27 ` Andy Shevchenko
2017-03-30 12:54 ` Willy TARREAU
2017-04-04 16:27 ` Andy Shevchenko
2017-03-27 14:12 ` Arnd Bergmann
2017-03-27 14:15 ` Geert Uytterhoeven
2017-03-30 11:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327081111.GA28802@haproxy.com \
--to=wtarreau@haproxy.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).