From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] hpet: remove unused writeq/readq function definitions
Date: Mon, 27 Mar 2017 10:53:55 +0200 [thread overview]
Message-ID: <20170327085355.GB12523@Red> (raw)
In-Reply-To: <4473d49a-5203-a916-fdb6-402abfde5275@ladisch.de>
On Mon, Mar 27, 2017 at 09:51:23AM +0200, Clemens Ladisch wrote:
> Corentin Labbe wrote:
> > On Mon, Mar 27, 2017 at 07:49:34AM +0800, kbuild test robot wrote:
> >> drivers//char/hpet.c: In function 'hpet_timer_set_irq':
> >>>> drivers//char/hpet.c:207:7: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
> >
> > Wrongly believed that x86 and x86_64 shared writeq/readq.
> > Sorry, I will drop this patch
> >
> > Since the writeq/readq redefined is present in lots of other file, perhaps adding it to i386 could be done.
>
> Just use <linux/io-64-nonatomic-lo-hi.h> instead.
>
Thanks, much easier than add writeq/readq to whole x86
Regards
next prev parent reply other threads:[~2017-03-27 8:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 14:43 [PATCH 0/6] hpet: misc fix Corentin Labbe
2017-03-25 14:43 ` [PATCH 1/6] hpet: remove unused variable hpet in hpet_ioctl_common Corentin Labbe
2017-03-25 14:43 ` [PATCH 2/6] hpet: remove unused writeq/readq function definitions Corentin Labbe
2017-03-26 23:49 ` kbuild test robot
2017-03-27 7:43 ` Corentin Labbe
2017-03-27 7:51 ` Clemens Ladisch
2017-03-27 8:53 ` Corentin Labbe [this message]
2017-03-25 14:43 ` [PATCH 3/6] hpet: fix checkpatch complains about spaces Corentin Labbe
2017-03-25 14:43 ` [PATCH 4/6] hpet: replace printk by their pr_xxx counterparts Corentin Labbe
2017-03-25 14:43 ` [PATCH 5/6] hpet: removing unused variable m in hpet_interrupt Corentin Labbe
2017-03-25 14:43 ` [PATCH 6/6] hpet: fix style issue about braces and alignment Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327085355.GB12523@Red \
--to=clabbe.montjoie@gmail.com \
--cc=arnd@arndb.de \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox