linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Klinger <ak@it-klinger.de>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linus.walleij@linaro.org, ddvlad@gmail.com,
	akinobu.mita@gmail.com, yongjun_wei@trendmicro.com.cn,
	a.mathur@samsung.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] IIO: bmp280-core.c: fix error in humidity calculation
Date: Mon, 27 Mar 2017 12:06:47 +0200	[thread overview]
Message-ID: <20170327100646.GA8128@project> (raw)

While calculating the compensation of the humidity there are negative
values interpreted as unsigned because of unsigned variables used.
These values need to be casted to signed as indicated by the documentation
of the sensor.

Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
 drivers/iio/pressure/bmp280-core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index 4d18826ac63c..73308f0ea260 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -177,9 +177,9 @@ static u32 bmp280_compensate_humidity(struct bmp280_data *data,
 
 	var = ((s32)data->t_fine) - 76800;
 	var = ((((adc_humidity << 14) - (H4 << 20) - (H5 * var)) + 16384) >> 15)
-		* (((((((var * H6) >> 10) * (((var * H3) >> 11) + 32768)) >> 10)
-		+ 2097152) * H2 + 8192) >> 14);
-	var -= ((((var >> 15) * (var >> 15)) >> 7) * H1) >> 4;
+		* (((((((var * H6) >> 10) * (((var * (s32)H3) >> 11) + 32768))
+		>> 10) + 2097152) * H2 + 8192) >> 14);
+	var -= ((((var >> 15) * (var >> 15)) >> 7) * (s32)H1) >> 4;
 
 	return var >> 12;
 };
-- 
2.1.4


-- 

             reply	other threads:[~2017-03-27 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 10:06 Andreas Klinger [this message]
2017-04-02  9:32 ` [PATCH] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron
2017-04-02 14:56   ` Linus Walleij
2017-04-02 17:29     ` Andreas Klinger
2017-04-02 17:46       ` Jonathan Cameron
2017-04-04  6:16       ` Matt Ranostay
2017-04-07  6:13         ` Matt Ranostay
2017-04-07 19:27           ` Andreas Klinger
2017-04-08 21:34             ` Matt Ranostay
2017-04-10 16:47               ` Andreas Klinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327100646.GA8128@project \
    --to=ak@it-klinger.de \
    --cc=a.mathur@samsung.com \
    --cc=akinobu.mita@gmail.com \
    --cc=ddvlad@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).