From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752740AbdC0MJA (ORCPT ); Mon, 27 Mar 2017 08:09:00 -0400 Received: from mail.us.es ([193.147.175.20]:49686 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbdC0MIw (ORCPT ); Mon, 27 Mar 2017 08:08:52 -0400 Date: Mon, 27 Mar 2017 14:08:27 +0200 From: Pablo Neira Ayuso To: Arushi Singhal Cc: Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] net: netfilter: Remove multiple assignment. Message-ID: <20170327120827.GA15676@salvia> References: <20170325124946.GA9109@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170325124946.GA9109@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote: > This patch removes multiple assignments. > Done using coccinelle. > @@ > identifier i1,i2; > constant c; > @@ > - i1=i2=c; > + i1=c; > + i2=c; You have to explain why this is bad.