From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbdC0MXE (ORCPT ); Mon, 27 Mar 2017 08:23:04 -0400 Received: from mail.us.es ([193.147.175.20]:58520 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752336AbdC0MWh (ORCPT ); Mon, 27 Mar 2017 08:22:37 -0400 Date: Mon, 27 Mar 2017 14:21:53 +0200 From: Pablo Neira Ayuso To: Arushi Singhal Cc: Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, LKML , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] Re: [PATCH] net: netfilter: Remove multiple assignment. Message-ID: <20170327122153.GA25113@salvia> References: <20170325124946.GA9109@arushi-HP-Pavilion-Notebook> <20170327120827.GA15676@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2017 at 05:48:41PM +0530, Arushi Singhal wrote: > On Mon, Mar 27, 2017 at 5:38 PM, Pablo Neira Ayuso > wrote: > > > On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote: > > > This patch removes multiple assignments. > > > Done using coccinelle. > > > @@ > > > identifier i1,i2; > > > constant c; > > > @@ > > > - i1=i2=c; > > > + i1=c; > > > + i2=c; > > > > You have to explain why this is bad. > > > > It is against the kernel coding style and we have to avoid multiple > assignments to make the code more readable. > This error is found using Checkpatch.pl script. Then, please place this information in your patch description. Thanks!