From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754653AbdC1HxJ (ORCPT ); Tue, 28 Mar 2017 03:53:09 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35480 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbdC1HxI (ORCPT ); Tue, 28 Mar 2017 03:53:08 -0400 Date: Tue, 28 Mar 2017 08:52:48 +0100 From: Sudip Mukherjee To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , Sudip Mukherjee , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH] serial: 8250_EXAR: fix duplicate Kconfig text and add missing help text Message-ID: <20170328075248.GA3992@sudip-tp> References: <20170327233910.13122-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327233910.13122-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 27, 2017 at 07:39:10PM -0400, Paul Gortmaker wrote: > In commit d0aeaa83f0b0f7a92615bbdd6b1f96812f7dcfd2 ("serial: exar: > split out the exar code from 8250_pci") the exar driver got its own > Kconfig. However the text for the new option was never changed from > the original 8250_PCI text, and hence it appears confusing when you > get asked the same question twice: > > 8250/16550 PCI device support (SERIAL_8250_PCI) [Y/n/m/?] (NEW) > 8250/16550 PCI device support (SERIAL_8250_EXAR) [Y/n/m] (NEW) > > Adding to the confusion, is that there is no help text for this new > option to indicate it is specific to a certain family of cards. > > Fix both issues at the same time, as well as the space vs. tab issues > introduced in the same commit. > > Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci") > Cc: Andy Shevchenko > Cc: Sudip Mukherjee Acked-by: Sudip Mukherjee