From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbdC1H4A (ORCPT ); Tue, 28 Mar 2017 03:56:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:10781 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754530AbdC1Hz6 (ORCPT ); Tue, 28 Mar 2017 03:55:58 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-b0-58da16e64f4a Date: Tue, 28 Mar 2017 16:55:18 +0900 From: Jaechul Lee To: Andi Shyti Cc: Dmitry Torokhov , Beomho Seo , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti Subject: Re: [PATCH] Input: tm2-touchkey - use LEN_ON as boolean value instead of LED_FULL Message-id: <20170328075518.GA16286@jcsing> MIME-version: 1.0 Content-type: text/plain; charset="us-ascii" Content-disposition: inline In-reply-to: <20170327132905.23133-1-andi.shyti@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLKsWRmVeSWpSXmKPExsWy7bCmuu5zsVsRBu+bWSy2H3nGarH4x3Mm i9OftrFbHF70gtHi5qdvrBaXd81hc2DzuL7kE7PHzll32T36tqxi9Pi8SS6AJSrVJiM1MSW1 SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdouZJCWWJOKVAoILG4 WEnfzqYov7QkVSEjv7jEVina0NBIz9DAXM/IyEjPxDjWysgUqCQhNePR+iOsBXN4KprmnWFr YJzH1cXIySEhYCJx+ehRJghbTOLCvfVsXYxcHEICSxkltlx4ygzhtDNJvO/azQbTsWnxFCaI xHJGielT3jJCOC8YJU49OwCU4eBgEVCVuPQwAaSBTUBLon9JD1iziIC6xJK9W5lBbGaBTYwS i59KgNjCAjESL1b2MILYvALaEm2/GtggbEGJH5PvsUDU60icPbaOEcKWlnj0dwY7yCpOARuJ 7y9LQExRARWJVwfrQa6REJjHLvHt7wuwayQEZCU2HWCGON9FYua951CvCEu8Or6FHcKWlvi7 9BYjRG87o8Shm1+hnA5GiX1XFkB1GEvcf3AP6n4+id7fT6AW8Ep0tAlBlHhIXHu1F2qoo8Sk V+/YIcHTzyjx5PQExgmM8rOQvDYLyWuzkLy2gJF5FaNYakFxbnpqsWmBkV5xYm5xaV66XnJ+ 7iZGcNLT0t3B+GWB9yFGAQ5GJR7eFfU3I4RYE8uKK3MPMUpwMCuJ8Epy34oQ4k1JrKxKLcqP LyrNSS0+xGgKjJ2JzFKiyfnAhJxXEm9oYmlgYmpmbGBsaGGpJM6rvvJahJBAemJJanZqakFq EUwfEwenVANjQUTjJs9ayffM7Eumvt+/cQnfBd9ns5mehWln2My8/j55nuDzy1Pcd00OnWo4 tUK07sbf6XvmTGFifqPwP5LDwzb48QLPd93RBxO/3Z+4hf/MBulYteKs7aeu3sx3+v14MTsz R9yUvND3Okei9XarXUqa4bry0wyu+TNS9ixxmKn4slDt5vyCIiWW4oxEQy3mouJEAO9mQ4mQ AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t9jAd1nYrciDE6/V7DYfuQZq8XiH8+Z LE5/2sZucXjRC0aLm5++sVpc3jWHzYHN4/qST8weO2fdZffo27KK0ePzJrkAlig3m4zUxJTU IoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZTxa f4S1YA5PRdO8M2wNjPO4uhg5OSQETCQ2LZ7CBGGLSVy4t54NxBYSWMoo8eKodhcjF5D9glGi 781Dli5GDg4WAVWJSw8TQGrYBLQk+pf0gNWLCKhLLNm7lRmknllgE6PE35N9zCAJYYEYiRXX ehlBbF4BbYm2Xw1sEEMnMkrMmrKQDSIhKPFj8j0WEJsZaOr6nceZIGxpiUd/Z7CDLOYUsJH4 /rIExBQVUJF4dbB+AqPALCTNs5A0z0LSvICReRWjRGpBckFxUnquUV5quV5xYm5xaV66XnJ+ 7iZGcDQ9k97BeHiX+yFGAQ5GJR5eDf6bEUKsiWXFlbmHGCU4mJVEeCW5b0UI8aYkVlalFuXH F5XmpBYfYjQFhsdEZinR5HxgpOeVxBuamJuYGxtYmFtamhgpifM2zn4WLiSQnliSmp2aWpBa BNPHxMEp1cAo+EXa5EP7a0NrffEJ0v3thl739s9N3HT1hHHnoon3fz8pnah87ThzeOGbzbIH g69Iaj0ISrrLw2o0Y/GVF6bLvrDs63+SIJHc/26GpMuSZx8fcuce+jDRwJup5adoXWzQ3dNz xKTOJAZt6I/xP3iVI0R1qs0a7eQfKobq2nNn8O4/fdRr/vLfSizFGYmGWsxFxYkAzKGuprwC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170328075518epcas5p190da50f1d2266336c2b9c6ed66aadf29 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7J207J6s7LKgG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SmFlQ2h1bCBMZWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170327132914epcas1p150dbc9723f4ff06329d3d3486ad666f7 X-RootMTR: 20170327132914epcas1p150dbc9723f4ff06329d3d3486ad666f7 References: <20170327132905.23133-1-andi.shyti@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, There is a typing error at the subject.(LEN_ON->LED_ON) Anyway, your patch is working well and looks good to me. I reviewed and tested with this patch on TM2. Reviewed-by: Jaechul Lee Tested-by: Jaechul Lee Best Regards, Jaechul Lee On Mon, Mar 27, 2017 at 10:29:05PM +0900, Andi Shyti wrote: > Commit 4e552c8cb5bc ("leds: add LED_ON brightness as boolean value") > has introduced the LED_ON enumeration value that can be used > instead of LED_FULL which has more of a linear value. > > Because the tm2-touchscreen doesn't have brightness levels, but > it's a simple on/off led, use LED_ON instead of LED_FULL. > > Signed-off-by: Andi Shyti > --- > drivers/input/keyboard/tm2-touchkey.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c > index 485900f953e0..abc266e40e17 100644 > --- a/drivers/input/keyboard/tm2-touchkey.c > +++ b/drivers/input/keyboard/tm2-touchkey.c > @@ -213,7 +213,7 @@ static int tm2_touchkey_probe(struct i2c_client *client, > /* led device */ > touchkey->led_dev.name = TM2_TOUCHKEY_DEV_NAME; > touchkey->led_dev.brightness = LED_FULL; > - touchkey->led_dev.max_brightness = LED_FULL; > + touchkey->led_dev.max_brightness = LED_ON; > touchkey->led_dev.brightness_set = tm2_touchkey_led_brightness_set; > > error = devm_led_classdev_register(&client->dev, &touchkey->led_dev); > -- > 2.11.0 >