From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, regressions@leemhuis.info,
Richard Weinberger <richard@nod.at>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ralph Sennhauser <ralph.sennhauser@gmail.com>
Subject: Re: [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs
Date: Tue, 28 Mar 2017 13:28:18 +0200 [thread overview]
Message-ID: <20170328132818.05871b73@gmail.com> (raw)
In-Reply-To: <CAOQ4uxgNfuLN93owdCUJ=9VcU4DKGVEKkEGT7siiem8quVwCsQ@mail.gmail.com>
Hi Amir,
On Tue, 28 Mar 2017 07:03:11 -0400
Amir Goldstein <amir73il@gmail.com> wrote:
> Overlayfs now uses O_TMPFILE for copy up and it works fine with all
> the file systems I tested (tmpfs, xfs, ext4).
> If I am right and O_TMPFILE is broken in ubifs, you are most likely
> the first person to test it (indirectly by overlayfs).
>
> Please try to reproduce the bug with following patch to disable ubifs
> O_TMPFILE support:
>
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -1685,7 +1685,7 @@ const struct inode_operations
> ubifs_dir_inode_operations = {
> #ifdef CONFIG_UBIFS_ATIME_SUPPORT
> .update_time = ubifs_update_time,
> #endif
> - .tmpfile = ubifs_tmpfile,
> + //.tmpfile = ubifs_tmpfile,
> };
Get a unused warning during build but all seems to be working fine now.
Thanks
Ralph
next prev parent reply other threads:[~2017-03-28 11:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:01 [REGRESSION 4.11] Commit d8514d8edb5b ("ovl: copy up regular file using O_TMPFILE") breaks ubifs Ralph Sennhauser
2017-03-28 9:27 ` Amir Goldstein
2017-03-28 10:43 ` Amir Goldstein
2017-03-29 21:06 ` Richard Weinberger
2017-03-28 10:45 ` Ralph Sennhauser
2017-03-28 11:03 ` Amir Goldstein
2017-03-28 11:28 ` Ralph Sennhauser [this message]
2017-03-28 12:08 ` Amir Goldstein
2017-03-28 12:16 ` Ralph Sennhauser
2017-03-29 19:16 ` Amir Goldstein
2017-03-29 21:26 ` Ralph Sennhauser
2017-03-29 22:15 ` Richard Weinberger
2017-03-30 5:53 ` Ralph Sennhauser
2017-03-30 6:34 ` Amir Goldstein
2017-03-30 7:18 ` Richard Weinberger
[not found] <pt0j2tw5gavgsksyh1yovnel.1490857017978@email.android.com>
2017-03-30 7:28 ` Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328132818.05871b73@gmail.com \
--to=ralph.sennhauser@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=amir73il@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=regressions@leemhuis.info \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox