From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932391AbdC1T34 (ORCPT ); Tue, 28 Mar 2017 15:29:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:45234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbdC1T3y (ORCPT ); Tue, 28 Mar 2017 15:29:54 -0400 Date: Tue, 28 Mar 2017 16:29:47 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Jin Yao , jolsa@kernel.org, Linux-kernel@vger.kernel.org, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1] perf report: Drop cycles 0 for LBR print Message-ID: <20170328192947.GD17135@kernel.org> References: <1489046786-10061-1-git-send-email-yao.jin@linux.intel.com> <20170328153452.GC17135@kernel.org> <20170328170544.GF9371@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328170544.GF9371@tassilo.jf.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Mar 28, 2017 at 10:05:44AM -0700, Andi Kleen escreveu: > On Tue, Mar 28, 2017 at 12:34:52PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Mar 09, 2017 at 04:06:26PM +0800, Jin Yao escreveu: > > > For some platforms, for example Broadwell, it doesn't support cycles > > > for LBR. But the perf always prints cycles:0, it's not necessary. > > > > > > The patch refactors the LBR info print code and drops the cycles:0. > > > > > > For example: perf report --branch-history --no-children --stdio > > > > Can I get some reviewed-by or acked-by for this patch? Andi? Kan? > > Reviewed-by: Andi Kleen Thanks, applied. - Arnaldo