From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754234AbdC2HdF (ORCPT ); Wed, 29 Mar 2017 03:33:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53804 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645AbdC2HdD (ORCPT ); Wed, 29 Mar 2017 03:33:03 -0400 Date: Wed, 29 Mar 2017 09:32:42 +0200 From: Greg KH To: Andrii Cc: sergio.paracuellos@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] staging: wlan-ng: fix avoid multiple line dereference warning reported by checkpatch.pl Message-ID: <20170329073242.GC8459@kroah.com> References: <20170311223956.79ded6a2@andrii-VirtualBox> <20170312173009.7d0fc710@andrii-VirtualBox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170312173009.7d0fc710@andrii-VirtualBox> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 12, 2017 at 05:30:09PM +0200, Andrii wrote: > Fixed three code style warnings (multiple line dereference) reported > by checkpatch.pl script. > > Signed-off-by: Andrii Vladyka > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 6134eba..a050748 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -1346,14 +1346,8 @@ hfa384x_docmd(struct hfa384x *hw, > } else if (mode == DOWAIT) { > struct usbctlx_cmd_completor completor; > > - result = > - hfa384x_usbctlx_complete_sync(hw, ctlx, > - init_cmd_completor(&completor, > - &ctlx-> > - inbuf. > - cmdresp, > - &cmd-> > - result)); > + result = hfa384x_usbctlx_complete_sync(hw, ctlx, > + init_cmd_completor(&completor, &ctlx->inbuf.cmdresp, &cmd->result)) Ick, no, that doesn't look right, does it? Please use your brain when making checkpatch changes, it's just a dumb perl script... greg k-h