From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755991AbdC2KeZ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 06:34:25 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:40766 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755904AbdC2KeX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 06:34:23 -0400
Date: Wed, 29 Mar 2017 12:34:05 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: devel@driverdev.osuosl.org, Doug Oucharek <doug.s.oucharek@intel.com>,
        linux-kernel@vger.kernel.org, Oleg Drokin <oleg.drokin@intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Andreas Dilger <andreas.dilger@intel.com>,
        lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lusten: conrpc.c: fix different address space
 sparse warning
Message-ID: <20170329103405.GA4087@kroah.com>
References: <20170329021409.24537-1-marcos.souza.org@gmail.com>
 <20170329073114.GA8459@kroah.com>
 <20170323190901.GA22066@builder>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170323190901.GA22066@builder>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2017 at 04:09:03PM -0300, Marcos Paulo de Souza wrote:
> On Wed, Mar 29, 2017 at 09:31:14AM +0200, Greg KH wrote:
> > On Tue, Mar 28, 2017 at 11:14:06PM -0300, Marcos Paulo de Souza wrote:
> > > head_up parameter is marked with __user attribute, tmp is filled
> > > by a copy_from_user from next, that is also marked as __user, so
> > > tmp.next needs to be "casted" as __user to make sparse happy.
> > 
> > But is it the correct change?
> 
> I don't know, it's my first sparse patch, so I tried to fix this
> warning.
> 
> > 
> > You also have a typo in your subject :(
> 
> Sorry, didn't noticed yesterday :(
> 
> > 
> > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > > ---
> > > 
> > >  this is mt first patch addressing an issue of sparse, so let me know
> > >  if I misunderstood the error message
> > > 
> > >  drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
> > > index c6a683b..fb7ad74 100644
> > > --- a/drivers/staging/lustre/lnet/selftest/conrpc.c
> > > +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
> > > @@ -487,7 +487,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans,
> > >  				   sizeof(struct list_head)))
> > >  			return -EFAULT;
> > >  
> > > -		if (tmp.next == head_up)
> > > +		if ((struct list_head __user *)tmp.next == head_up)
> > 
> > Aer you sure this is correct?  __user changes for lustre is not
> > trivial...
> > 
> > How did you test this?
> 
> I didn't tested, it just removed the warning. Is this a false positive?

I don't know, it's up to you to prove to me that you know this change is
correct.  You have to justify your changes, and "because checkpatch.pl
complained" isn't a valid justification for something like this :)

thanks,

greg k-h