From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753661AbdC2TUI (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Mar 2017 15:20:08 -0400
Received: from mail-pg0-f68.google.com ([74.125.83.68]:34334 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752129AbdC2TUG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Mar 2017 15:20:06 -0400
Date: Wed, 29 Mar 2017 12:20:02 -0700
From: Eric Biggers <ebiggers3@gmail.com>
To: Bilal Amarni <bilal.amarni@gmail.com>
Cc: dhowells@redhat.com, arnd@arndb.de, james.l.morris@oracle.com,
        serge@hallyn.com, keyrings@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: security/keys: add CONFIG_KEYS_COMPAT to Kconfig
Message-ID: <20170329192002.GA29310@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1486674698-67190-1-git-send-email-bilal.amarni@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu,  9 Feb 2017 22:11:38 +0100, Bilal Amarni wrote:
> CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for
> several 64-bit architectures : arm64, mips, parisc, tile.
> 
> At the moment and for those architectures, calling in 32-bit userspace the
> keyctl syscall would return an ENOSYS error.
> 
> This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to
> make sure the compatibility wrapper is registered by default for any 64-bit
> architecture as long as it is configured with CONFIG_COMPAT.

David, where can I find the git branch this patch was applied to?  I don't see
it anywhere in security-keys or linux-security.

I recently added KEYS_COMPAT to arm64 (5c2a625937ba); that should be reverted
after this patch.

Also, I'd like to submit a follow-on patch that removes KEYS_COMPAT and simply
uses COMPAT.

And the parisc architecture doesn't use compat_sys_keyctl() in its compat
syscall table, so that should be fixed too (though that's not a new bug).

- Eric