From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Michał Kępień" <kernel@kempniu.pl>,
"Jonathan Woithe" <jwoithe@just42.net>,
"Andy Shevchenko" <andy@infradead.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling
Date: Wed, 29 Mar 2017 20:36:50 -0700 [thread overview]
Message-ID: <20170330033650.GF15472@localhost.localdomain> (raw)
In-Reply-To: <CAHp75Ve2ToZW+Mp=HexjzhV82ZS38QkfK2bMxeRwuX3vu1bCsw@mail.gmail.com>
On Wed, Mar 29, 2017 at 07:35:50PM +0300, Andy Shevchenko wrote:
> On Wed, Mar 29, 2017 at 10:19 AM, Michał Kępień <kernel@kempniu.pl> wrote:
>
> > Darren, Andy, in light of the above I will be awaiting your review of
> > this series. I will submit v2 afterwards, with all remarks from both
> > you and Jonathan taken into account.
>
> Darren marked this series under his name to review, so, I let him to
> speak for us.
The series looks good to me. Nice work Michał. They are logically divided and
address issues in a procedural way (so I stopped commenting until I read the
full series through as a couple of times you addressed a concern from a move in
a cleanup to follow).
I've applied the noted change to 7/8 and will run this through my tests, but
don't anticipate any problems. Jonathan, if you don't have any additional
concerns, let me know if I can add your Reviewed-by.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-03-30 3:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:32 [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Michał Kępień
2017-03-20 9:32 ` [PATCH 1/8] platform/x86: fujitsu-laptop: move backlight input device setup to a separate function Michał Kępień
2017-03-29 19:54 ` Darren Hart
2017-03-30 4:04 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 2/8] platform/x86: fujitsu-laptop: switch to a managed backlight input device Michał Kępień
2017-03-29 19:58 ` Darren Hart
2017-03-20 9:32 ` [PATCH 3/8] platform/x86: fujitsu-laptop: use a sparse keymap for brightness key event generation Michał Kępień
2017-03-20 9:32 ` [PATCH 4/8] platform/x86: fujitsu-laptop: move hotkey input device setup to a separate function Michał Kępień
2017-03-29 20:12 ` Darren Hart
2017-03-20 9:32 ` [PATCH 5/8] platform/x86: fujitsu-laptop: switch to a managed hotkey input device Michał Kępień
2017-03-20 9:32 ` [PATCH 6/8] platform/x86: fujitsu-laptop: use a sparse keymap for hotkey event generation Michał Kępień
2017-03-31 11:22 ` Michał Kępień
2017-04-01 20:00 ` Darren Hart
2017-04-02 9:01 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 7/8] platform/x86: fujitsu-laptop: model-dependent sparse keymap overrides Michał Kępień
2017-03-27 0:40 ` Jonathan Woithe
2017-03-20 9:32 ` [PATCH 8/8] platform/x86: fujitsu-laptop: remove keycode fields from struct fujitsu_bl Michał Kępień
2017-03-24 10:49 ` [PATCH 0/8] fujitsu-laptop: use sparse keymaps for input event handling Jonathan Woithe
2017-03-27 23:57 ` Jonathan Woithe
2017-03-28 6:16 ` Michał Kępień
2017-03-28 23:00 ` Jonathan Woithe
2017-03-29 7:19 ` Michał Kępień
2017-03-29 16:35 ` Andy Shevchenko
2017-03-30 3:36 ` Darren Hart [this message]
2017-03-30 3:56 ` Jonathan Woithe
2017-03-30 5:04 ` Darren Hart
2017-03-30 6:41 ` Michał Kępień
2017-03-30 22:25 ` Jonathan Woithe
2017-03-29 19:28 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330033650.GF15472@localhost.localdomain \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=jwoithe@just42.net \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox