From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932849AbdC3Jyz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Mar 2017 05:54:55 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:35381 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932395AbdC3Jyw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Mar 2017 05:54:52 -0400
Date: Thu, 30 Mar 2017 11:54:48 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] x86/platform/intel-mid: Enable bluetooth on Intel
 Edison
Message-ID: <20170330095448.GA15232@gmail.com>
References: <20170329141815.34228-1-andriy.shevchenko@linux.intel.com>
 <20170330072345.GB12758@gmail.com>
 <1490867082.708.58.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1490867082.708.58.camel@linux.intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Thu, 2017-03-30 at 09:23 +0200, Ingo Molnar wrote:
> > * Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > 
> > > Intel Edison has Wi-Fi + BT module attached and, since it's an SFI-
> > > enumerated
> > > platform, needs a platform data. Here we add bits to enable
> > > bluetooth device.
> 
> > > +
> > > +static struct gpiod_lookup_table tng_bt_sfi_gpio_table = {
> > > +	.dev_id	= "hci_bcm",
> > > +	.table	= {
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> > > GPIO_ACTIVE_HIGH),
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "shutdown",
> > > GPIO_ACTIVE_HIGH),
> > > +		GPIO_LOOKUP("0000:00:0c.0", -1, "host-wakeup",
> > > GPIO_ACTIVE_HIGH),
> > 
> > Minor nit: just out of general principle (because the rest of the code
> > looks so 
> > nice) I'd properly tabulate the last column as well - something like:
> > 
> > 		GPIO_LOOKUP("0000:00:0c.0", -1, "device-wakeup",
> > GPIO_ACTIVE_HIGH),
> > 		GPIO_LOOKUP("0000:00:0c.0", -1,
> > "shutdown",      GPIO_ACTIVE_HIGH),
> > 		GPIO_LOOKUP("0000:00:0c.0", -1, "host-
> > wakeup",   GPIO_ACTIVE_HIGH),
> > 
> > Formatted that way the reviewer's eye can skip over those values in
> > 100 
> > milliseconds, determining that all 3 values are GPIO_ACTIVE_HIGH.
> 
> Thanks for a hint.
> Should I resend it?

Yeah, please send a v2.

Thanks!

	Ingo