public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Chris Zankel <chris@zankel.net>,
	"linux-xtensa@linux-xtensa.org" <linux-xtensa@linux-xtensa.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xtensa: Fix mmap() support
Date: Thu, 30 Mar 2017 12:05:22 +0200	[thread overview]
Message-ID: <20170330120522.4af7bcbc@bbrezillon> (raw)
In-Reply-To: <CAMo8Bf+D1kr8UtOQ+e86MtN9=mMO9KsJvY62qOXCyEBF_Jj-yA@mail.gmail.com>

On Thu, 30 Mar 2017 02:05:28 -0700
Max Filippov <jcmvbkbc@gmail.com> wrote:

> On Thu, Mar 30, 2017 at 1:30 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> >> Could you please instead check if the dma_common_mmap works for you
> >> with the attached patch?  
> >
> > I will. BTW, shouldn't it be
> >
> >         if (off >= XCHAL_KSEG_SIZE)
> >
> > instead of
> >
> >         if (off > XCHAL_KSEG_SIZE)
> > ?  
> 
> Oops. Yes, you're right.
> 

It works, you can add my

Tested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

when submitting the patch.

Thanks,

Boris

      reply	other threads:[~2017-03-30 10:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28  8:20 [PATCH] xtensa: Fix mmap() support Boris Brezillon
2017-03-29 22:48 ` Max Filippov
2017-03-30  8:30   ` Boris Brezillon
2017-03-30  8:45     ` Christoph Hellwig
2017-03-30  9:05     ` Max Filippov
2017-03-30 10:05       ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330120522.4af7bcbc@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=chris@zankel.net \
    --cc=hch@infradead.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox