From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933990AbdC3NbV (ORCPT ); Thu, 30 Mar 2017 09:31:21 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52228 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933844AbdC3NbK (ORCPT ); Thu, 30 Mar 2017 09:31:10 -0400 Date: Thu, 30 Mar 2017 15:30:46 +0200 From: jacopo To: Arushi Singhal Cc: outreachy-kernel@googlegroups.com, Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: replace comma with a semicolon Message-ID: <20170330133046.GA7900@w540> References: <20170330124603.GA29301@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170330124603.GA29301@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arushi, thanks for your patch On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > Replace a comma between expression statements by a semicolon. This > changes the semantics of the code, but given the current indentation > appears to be what is intended. > A simplified version of the Coccinelle semantic patch that performs this > transformation is as follows: > > // > @r@ > expression e1,e2; > @@ > > e1 > -, > +; > e2; > // > You can simply say that this fixes what appears to be a bug to me. I wonder how this does even compile.. Jonathan, since I assume you picked this up and changed those 2 lines (original patch here [1]), was this intentional? Thanks j [1] https://marc.info/?l=linux-iio&m=148475728729617&w=2 > Signed-off-by: Arushi Singhal > --- > drivers/iio/adc/max11100.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c > index 23c060e1b663..1180bcc22ff1 100644 > --- a/drivers/iio/adc/max11100.c > +++ b/drivers/iio/adc/max11100.c > @@ -124,8 +124,8 @@ static int max11100_probe(struct spi_device *spi) > indio_dev->name = "max11100"; > indio_dev->info = &max11100_info; > indio_dev->modes = INDIO_DIRECT_MODE; > - indio_dev->channels = max11100_channels, > - indio_dev->num_channels = ARRAY_SIZE(max11100_channels), > + indio_dev->channels = max11100_channels; > + indio_dev->num_channels = ARRAY_SIZE(max11100_channels); > > state->vref_reg = devm_regulator_get(&spi->dev, "vref"); > if (IS_ERR(state->vref_reg)) > -- > 2.11.0 >