From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934031AbdC3Nk6 (ORCPT ); Thu, 30 Mar 2017 09:40:58 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35812 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933600AbdC3NkI (ORCPT ); Thu, 30 Mar 2017 09:40:08 -0400 From: Johan Hovold To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/3] tty: drop obsolete termios_locked comments Date: Thu, 30 Mar 2017 15:39:35 +0200 Message-Id: <20170330133936.17907-3-johan@kernel.org> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170330133936.17907-1-johan@kernel.org> References: <20170330133936.17907-1-johan@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop comments about tty-driver termios_locked structures, which have been outdated since commit fe6e29fdb1a7 ("tty: simplify ktermios allocation"). Signed-off-by: Johan Hovold --- drivers/tty/tty_io.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 8e9651579d50..5f834dcb0b15 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -1520,7 +1520,7 @@ struct tty_struct *tty_init_dev(struct tty_driver *driver, int idx) * This code guarantees that either everything succeeds and the * TTY is ready for operation, or else the table slots are vacated * and the allocated memory released. (Except that the termios - * and locked termios may be retained.) + * may be retained.) */ if (!try_module_get(driver->owner)) @@ -3441,11 +3441,6 @@ static void destruct_tty_driver(struct kref *kref) struct ktermios *tp; if (driver->flags & TTY_DRIVER_INSTALLED) { - /* - * Free the termios and termios_locked structures because - * we don't want to get memory leaks when modular tty - * drivers are removed from the kernel. - */ for (i = 0; i < driver->num; i++) { tp = driver->termios[i]; if (tp) { -- 2.12.2