From: Thierry Reding <treding@nvidia.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: David Miller <davem@davemloft.net>, <arnd@arndb.de>,
<peppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
<Joao.Pinto@synopsys.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues
Date: Thu, 30 Mar 2017 16:34:36 +0200 [thread overview]
Message-ID: <20170330143435.GA28098@ulmo.ba.sec> (raw)
In-Reply-To: <20170330074536.GA4814@Red>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote:
> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > Date: Tue, 28 Mar 2017 11:48:21 +0200
> >
> > > A driver must not access the two fields directly but should instead use
> > > the helper functions to set the values and keep a consistent internal
> > > state:
> > >
> > > ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
> > > ethernet/stmicro/stmmac/stmmac_main.c:4083:8: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
> > >
> > > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Applied.
>
> This break my revert patch. (since it patch ("net: stmmac: enable multiple buffers").
> Since dwmac-sunxi is still broken, what can I do ? send two revert patch ? or adapt the reverting patch.
Have you tried if the kcalloc() patch I sent on Tuesday fixes things the
issues introduced by the multiple buffers patch? Niklas reported that it
restores functionality on his setup.
If it makes things work for you as well, we could maybe avoid the revert
altogether.
You can find the patch here:
https://patchwork.ozlabs.org/patch/744286/
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-30 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:48 [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues Arnd Bergmann
2017-03-29 1:01 ` David Miller
2017-03-30 7:45 ` Corentin Labbe
2017-03-30 14:34 ` Thierry Reding [this message]
2017-03-30 16:35 ` Niklas Cassel
2017-03-30 16:42 ` Joao Pinto
2017-04-03 13:07 ` Giuseppe CAVALLARO
2017-04-03 13:12 ` Joao Pinto
2017-04-04 6:15 ` Giuseppe CAVALLARO
2017-03-30 17:48 ` David Miller
2017-03-31 10:14 ` Joao Pinto
2017-03-31 10:43 ` Joao Pinto
2017-03-31 16:57 ` David Miller
2017-03-31 16:58 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330143435.GA28098@ulmo.ba.sec \
--to=treding@nvidia.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox