From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934388AbdC3QlM (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Mar 2017 12:41:12 -0400
Received: from mail-pg0-f44.google.com ([74.125.83.44]:33968 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933205AbdC3QlJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Mar 2017 12:41:09 -0400
Date: Thu, 30 Mar 2017 09:41:06 -0700
From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <mmarek@suse.com>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Behan Webster <behanw@converseincode.com>,
        Greg Hackmann <ghackmann@google.com>,
        Grant Grundler <grundler@chromium.org>,
        Michael Davidson <md@google.com>, Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] kbuild: use -Oz instead of -Os when using clang
Message-ID: <20170330164106.GA2130@google.com>
References: <20170328011909.150513-1-mka@chromium.org>
 <CAK7LNATU+JNx2eZCTuqyws=CQL3Z2p6QJ7Oa0DNMvxbNJNH4Jg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAK7LNATU+JNx2eZCTuqyws=CQL3Z2p6QJ7Oa0DNMvxbNJNH4Jg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

El Fri, Mar 31, 2017 at 01:03:02AM +0900 Masahiro Yamada ha dit:

> 2017-03-28 10:19 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> > This generates smaller resulting object code when compiled with clang.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >  Makefile | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index b2faa9319372..66bcdbf58371 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -638,7 +638,8 @@ KBUILD_CFLAGS       += $(call cc-option,-fdata-sections,)
> >  endif
> >
> >  ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
> > -KBUILD_CFLAGS  += -Os $(call cc-disable-warning,maybe-uninitialized,)
> > +KBUILD_CFLAGS  += $(call cc-option,-Oz,-Os)
> > +KBUILD_CFLAGS  += $(call cc-disable-warning,maybe-uninitialized,)
> >  else
> >  ifdef CONFIG_PROFILE_ALL_BRANCHES
> >  KBUILD_CFLAGS  += -O2 $(call cc-disable-warning,maybe-uninitialized,)
> >
> 
> 
> 
> This is the same as the following commit in LLVMLinux
> except Author/Signed-off-by.
> 
> Who should the authorship really belong to?

(this time without html, sorry for the noise)

It should belong to Behan, I missed to add a 'From' tag, sorry about
that. Should I resend with the tag or can you fix it when applying the
patch?

Matthias

> commit 186e62808239c603bfa308d5ea994a10d67bb409
> Author: Behan Webster <behanw@converseincode.com>
> Date:   Thu Oct 16 14:28:54 2014 +0200
> 
>     LLVMLinux: use -Oz instead of -Os when using clang
> 
>     This generates smaller resulting object code when compiled with clang.
> 
>     Signed-off-by: Behan Webster <behanw@converseincode.com>
> 
>