From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755379AbdCaJBq (ORCPT ); Fri, 31 Mar 2017 05:01:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44986 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754736AbdCaJBl (ORCPT ); Fri, 31 Mar 2017 05:01:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8B20B41A2D Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8B20B41A2D Date: Fri, 31 Mar 2017 11:01:31 +0200 From: Benjamin Tissoires To: Colin King Cc: Jiri Kosina , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: sony: remove redundant check for -ve err Message-ID: <20170331090131.GG22683@mail.corp.redhat.com> References: <20170327175118.28322-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170327175118.28322-1-colin.king@canonical.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 31 Mar 2017 09:01:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mar 27 2017 or thereabouts, Colin King wrote: > From: Colin Ian King > > err is being checked for failure each time it is being updated > so this err check is totally redundant and can be removed > > Detected with CoverityScan, CID#1420665 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- Indeed. Not sure if it will conflict with Roderick's series, but still: Reviewed-by: Benjamin Tissoires Cheers, Benjamin > drivers/hid/hid-sony.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c > index bb124e339d26..e3c6fe554056 100644 > --- a/drivers/hid/hid-sony.c > +++ b/drivers/hid/hid-sony.c > @@ -2614,9 +2614,6 @@ static int sony_input_configured(struct hid_device *hdev, > ret = 0; > } > > - if (ret < 0) > - goto err_stop; > - > if (sc->quirks & SONY_LED_SUPPORT) { > ret = sony_leds_init(sc); > if (ret < 0) > -- > 2.11.0 >