From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933143AbdCaMde (ORCPT ); Fri, 31 Mar 2017 08:33:34 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:32773 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892AbdCaMdd (ORCPT ); Fri, 31 Mar 2017 08:33:33 -0400 X-ME-Sender: X-Sasl-enc: WqblOqpJXVPrCDFh2MNVs8S+ZQFP3/7Z7L0dnY9y1vkk 1490963611 Date: Fri, 31 Mar 2017 14:33:17 +0200 From: Greg KH To: Chewie Lin Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Message-ID: <20170331123317.GA17717@kroah.com> References: <20170331100112.8106-1-linsh@oregonstate.edu> <20170331100112.8106-2-linsh@oregonstate.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170331100112.8106-2-linsh@oregonstate.edu> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote: > fix a checkpatch warning: > WARNING: Prefer using "%s", __func__ to embedded function names > > Signed-off-by: Chewie Lin > --- > drivers/staging/vt6656/main_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > index 9e074e9..2d9e7af 100644 > --- a/drivers/staging/vt6656/main_usb.c > +++ b/drivers/staging/vt6656/main_usb.c > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > status = usb_reset_device(priv->usb); > if (status) > dev_warn(&priv->usb->dev, > - "usb_device_reset fail status=%d\n", status); > + "%s=%d\n", "usb_device_reset fail status", status); Your patch does not match your description at all :(