From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933228AbdCaNlN (ORCPT ); Fri, 31 Mar 2017 09:41:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35732 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932854AbdCaNlL (ORCPT ); Fri, 31 Mar 2017 09:41:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 47C7AC049D5D Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rkrcmar@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 47C7AC049D5D Date: Fri, 31 Mar 2017 15:41:07 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lei.cao@stratus.com Subject: Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture agnostic Message-ID: <20170331134106.GC6019@potion> References: <1490961203-7139-1-git-send-email-pbonzini@redhat.com> <1490961203-7139-2-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490961203-7139-2-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 31 Mar 2017 13:41:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-03-31 13:53+0200, Paolo Bonzini: > Remove code from architecture files that can be moved to virt/kvm, since there > is already common code for coalesced MMIO. > > Signed-off-by: Paolo Bonzini > --- > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > @@ -2919,6 +2919,11 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg) > +#ifdef KVM_COALESCED_MMIO_PAGE_OFFSET > + case KVM_CAP_COALESCED_MMIO: > + return KVM_COALESCED_MMIO_PAGE_OFFSET; > + break; This 'break;' is pointless and would be best removed when applying, thanks. > +#endif