From: Chewie Lin <linsh@oregonstate.edu>
To: Joe Perches <joe@perches.com>
Cc: greg@kroah.com, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: fixed a checkpatch warning
Date: Fri, 31 Mar 2017 20:28:43 -0700 [thread overview]
Message-ID: <20170401032843.GB9149@Cassini.Home> (raw)
In-Reply-To: <1490986435.27353.22.camel@perches.com>
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote:
> > fixed a coding style error/warning.
> >
> > Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> > ---
> > drivers/staging/vt6656/main_usb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> > index 9e074e9..2d9e7af 100644
> > --- a/drivers/staging/vt6656/main_usb.c
> > +++ b/drivers/staging/vt6656/main_usb.c
> > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> > status = usb_reset_device(priv->usb);
> > if (status)
> > dev_warn(&priv->usb->dev,
> > - "usb_device_reset fail status=%d\n", status);
> > + "%s=%d\n", "usb_device_reset fail status", status);
>
> Yeah, what Greg said.
>
> Also most likely this should be
>
> dev_warn(&priv->usb->dev,
> "usb_reset_device fail status=%d\n", status);
>
> Note the function is usb_device_reset, but the
> function call that failed is usb_reset_device.
yep, I had the comic book guy from the Simpsons voice when I read that. :)
I submitted a separate patch, maybe I should have reply-to this instead?
>
prev parent reply other threads:[~2017-04-01 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 8:40 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 8:40 ` [PATCH] drivers: fixed a checkpatch warning Chewie Lin
2017-03-31 9:04 ` Greg KH
2017-03-31 18:53 ` Joe Perches
2017-04-01 3:28 ` Chewie Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170401032843.GB9149@Cassini.Home \
--to=linsh@oregonstate.edu \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox