From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751334AbdDADqa (ORCPT ); Fri, 31 Mar 2017 23:46:30 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:37828 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdDADq3 (ORCPT ); Fri, 31 Mar 2017 23:46:29 -0400 Date: Sat, 1 Apr 2017 04:46:23 +0100 From: Al Viro To: Joe Perches Cc: Chewie Lin , greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Message-ID: <20170401034623.GE29622@ZenIV.linux.org.uk> References: <20170401015919.9181-1-linsh@oregonstate.edu> <20170401015919.9181-2-linsh@oregonstate.edu> <20170401033239.GD29622@ZenIV.linux.org.uk> <1491017782.27353.33.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491017782.27353.33.camel@perches.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 31, 2017 at 08:36:22PM -0700, Joe Perches wrote: > On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote: > > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote: > > > Replace string with formatted arguments in the dev_warn() call. It removes > > > the checkpatch warning: > > > > > > WARNING: Prefer using "%s", __func__ to embedded function names > [] > > Again, checkpatch warning is badly written > > In your opinion, what wording would be better? MILD SUGGESTION: don't spell the function name out in format strings; "this_function: foo is %d", n might be better off as "%s: foo is %d", __func__, n in case you ever move it to another function or rename your function.