From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752019AbdDAROT (ORCPT <rfc822;w@1wt.eu>);
        Sat, 1 Apr 2017 13:14:19 -0400
Received: from mail-pg0-f67.google.com ([74.125.83.67]:35492 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751772AbdDAROR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 1 Apr 2017 13:14:17 -0400
Date: Sat, 1 Apr 2017 10:14:14 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
        dbasehore@google.com, dianders@chromium.org,
        Gwendal Grignou <gwendal@chromium.org>,
        Vic Yang <victoryang@google.com>, linux-input@vger.kernel.org,
        Enric Balletbo Serra <enric.balletbo@collabora.com>,
        Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] input: cros_ec_keyb: Report wakeup events
Message-ID: <20170401171414.GI17130@dtor-ws>
References: <1490867450-31765-1-git-send-email-jeffy.chen@rock-chips.com>
 <1490867450-31765-2-git-send-email-jeffy.chen@rock-chips.com>
 <20170401171237.GH17130@dtor-ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170401171237.GH17130@dtor-ws>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 01, 2017 at 10:12:37AM -0700, Dmitry Torokhov wrote:
> Hi Jeffy,
> 
> On Thu, Mar 30, 2017 at 05:50:49PM +0800, Jeffy Chen wrote:
> > Report wakeup events when process events.
> > 
> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> > ---
> > 
> >  drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> > index 6a250d6..a93d55f 100644
> > --- a/drivers/input/keyboard/cros_ec_keyb.c
> > +++ b/drivers/input/keyboard/cros_ec_keyb.c
> > @@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
> >  		return NOTIFY_DONE;
> >  	}
> >  
> > +	if (device_may_wakeup(ckdev->dev))
> > +		pm_wakeup_event(ckdev->dev, 0);
> > +
> >  	return NOTIFY_OK;
> >  }
> >  
> > @@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
> >  		return err;
> >  	}
> >  
> > +	err = device_init_wakeup(dev, 1);
> 
> In the other patch you are adding "wakeup-source" to the DT binding, but
> here you mark all EC deices as wakeup sources. You need to use
> device_property_read_bool(dev, "wakeup-source") and use the result in
> call to device_init_wakeup().

And please also update device tree binding doc for the driver.

> 
> > +	if (err) {
> > +		dev_err(dev, "cannot init wakeup: %d\n", err);
> > +		return err;
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> 
> Thanks.
> 
> -- 
> Dmitry

-- 
Dmitry