From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org,
Peter Korsgaard <peter.korsgaard@barco.com>,
Guenter Roeck <linux@roeck-us.net>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/9] Unify i2c_mux_add_adapter error reporting
Date: Mon, 3 Apr 2017 12:27:23 +0200 [thread overview]
Message-ID: <20170403102722.GB2750@katana> (raw)
In-Reply-To: <1491208718-32068-1-git-send-email-peda@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Mon, Apr 03, 2017 at 10:38:29AM +0200, Peter Rosin wrote:
> Hi!
>
> Many users of the i2c_mux_add_adapter interface log a message
> on failure, but the function already logs such a message. One
> or two of those users actually add more information than already
> provided by the central failure message.
>
> So, first fix the central error reporting to provide as much
> information as any current user, and then remove the surplus
> error reporting at the call sites.
Yes, I like.
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-03 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 8:38 [PATCH 0/9] Unify i2c_mux_add_adapter error reporting Peter Rosin
2017-04-03 8:38 ` [PATCH 1/9] i2c: mux: provide more info on failure in i2c_mux_add_adapter Peter Rosin
2017-04-03 8:38 ` [PATCH 2/9] i2c: arb: gpio-challenge: stop double error reporting Peter Rosin
2017-04-03 8:38 ` [PATCH 3/9] i2c: mux: gpio: " Peter Rosin
2017-04-03 8:38 ` [PATCH 4/9] i2c: mux: pca9541: " Peter Rosin
2017-04-03 8:38 ` [PATCH 5/9] i2c: mux: pca954x: " Peter Rosin
2017-04-03 8:38 ` [PATCH 6/9] i2c: mux: pinctrl: " Peter Rosin
2017-04-03 8:38 ` [PATCH 7/9] i2c: mux: reg: " Peter Rosin
2017-04-03 8:38 ` [PATCH 8/9] iio: gyro: mpu3050: " Peter Rosin
2017-04-03 17:56 ` Linus Walleij
2017-04-03 19:42 ` Jonathan Cameron
2017-04-03 8:38 ` [PATCH 9/9] [media] cx231xx: " Peter Rosin
2017-04-03 10:26 ` Wolfram Sang
2017-04-03 11:13 ` Peter Rosin
2017-04-03 10:27 ` Wolfram Sang [this message]
2017-04-03 11:27 ` [PATCH 0/9] Unify i2c_mux_add_adapter " Peter Rosin
2017-04-19 10:29 ` Mauro Carvalho Chehab
2017-04-11 8:08 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403102722.GB2750@katana \
--to=wsa@the-dreams.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox