public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	linux-kernel@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Subject: [PATCH v1] reset: Make optional stuff optional for all users
Date: Mon,  3 Apr 2017 15:26:38 +0300	[thread overview]
Message-ID: <20170403122638.88263-1-andriy.shevchenko@linux.intel.com> (raw)

There is Device Tree oriented check for optional resource. Of course
it will fail on non-DT platforms.

Remove this check to make things optional for all users.

Fixes: bb475230b8e5 ("reset: make optional functions really optional")
Cc: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

 The reset framework is too Device Tree oriented, and who knows what
 the logic was behind the commit which introduced devm_reset_*()
 functions without thinking out of the DT box.

 This commit fixes almost all Intel newest boards that have no legacy
 UART since UART driver started using this DT-centric framework.

 drivers/reset/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index f1e5e65388bb..62314e663f29 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -331,9 +331,6 @@ struct reset_control *__of_reset_control_get(struct device_node *node,
 	int rstc_id;
 	int ret;
 
-	if (!node)
-		return ERR_PTR(-EINVAL);
-
 	if (id) {
 		index = of_property_match_string(node,
 						 "reset-names", id);
-- 
2.11.0

             reply	other threads:[~2017-04-03 12:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 12:26 Andy Shevchenko [this message]
2017-04-03 14:27 ` [PATCH v1] reset: Make optional stuff optional for all users Philipp Zabel
2017-04-03 14:31   ` Andy Shevchenko
2017-04-03 14:33     ` Shevchenko, Andriy
2017-04-03 15:09       ` Philipp Zabel
2017-04-03 15:23         ` Andy Shevchenko
2017-04-03 16:04           ` Philipp Zabel
2017-04-03 20:48             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170403122638.88263-1-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Ramiro.Oliveira@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox