From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753195AbdDCOPA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Apr 2017 10:15:00 -0400
Received: from muru.com ([72.249.23.125]:43054 "EHLO muru.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751716AbdDCOO7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Apr 2017 10:14:59 -0400
Date: Mon, 3 Apr 2017 07:14:55 -0700
From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        Marcel Partap <mpartap@gmx.net>,
        Michael Scott <michael.scott@linaro.org>
Subject: Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts
Message-ID: <20170403141454.GG10760@atomide.com>
References: <20170322171052.7006-1-tony@atomide.com>
 <20170322171052.7006-3-tony@atomide.com>
 <20170403102122.c6bztacpqmt2xdzw@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170403102122.c6bztacpqmt2xdzw@dell>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

* Lee Jones <lee.jones@linaro.org> [170403 03:23]:
> On Wed, 22 Mar 2017, Tony Lindgren wrote:
> 
> > On CPCAP we need to keep reading interrupts until there are no
> > more interrupts. Otherwise the PMIC interrupt to the SoC will at
> > some point stop toggling. This seems to happen because new CPCAP
> > device interrupts show up while we're handling.
> > 
> > Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Marcel Partap <mpartap@gmx.net>
> > Cc: Michael Scott <michael.scott@linaro.org>
> > Tested-by: Sebastian Reichel <sre@kernel.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >  drivers/mfd/motorola-cpcap.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Applied, thanks.

Sorry this one depends on patch 1/4 for .handle_reread. So this
one should be reverted or dropped. That will cause trivial merge
conflicts with patches 2 and 4.

Please let me know if you want me to resend just patches 2 and 4
as patches 1 and 2 need more work.

Regards,

Tony

> > diff --git a/drivers/mfd/motorola-cpcap.c b/drivers/mfd/motorola-cpcap.c
> > --- a/drivers/mfd/motorola-cpcap.c
> > +++ b/drivers/mfd/motorola-cpcap.c
> > @@ -71,6 +71,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> >  		.ack_base = CPCAP_REG_MI1,
> >  		.mask_base = CPCAP_REG_MIM1,
> >  		.use_ack = true,
> > +		.handle_reread = true,
> >  	},
> >  	{
> >  		.name = "cpcap-m2",
> > @@ -79,6 +80,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> >  		.ack_base = CPCAP_REG_MI2,
> >  		.mask_base = CPCAP_REG_MIM2,
> >  		.use_ack = true,
> > +		.handle_reread = true,
> >  	},
> >  	{
> >  		.name = "cpcap1-4",
> > @@ -88,6 +90,7 @@ static struct regmap_irq_chip cpcap_irq_chip[CPCAP_NR_IRQ_CHIPS] = {
> >  		.mask_base = CPCAP_REG_INTM1,
> >  		.type_base = CPCAP_REG_INTS1,
> >  		.use_ack = true,
> > +		.handle_reread = true,
> >  	},
> >  };
> >  
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog