From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbdDDGxm (ORCPT ); Tue, 4 Apr 2017 02:53:42 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:45137 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdDDGxk (ORCPT ); Tue, 4 Apr 2017 02:53:40 -0400 Date: Mon, 3 Apr 2017 23:53:31 -0700 From: Christoph Hellwig To: Cathy Avery Cc: Christoph Hellwig , kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, stephen@networkplumber.org, dan.carpenter@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v2] scsi: storvsc: Add support for FC rport. Message-ID: <20170404065331.GA2626@infradead.org> References: <1491219195-3692-1-git-send-email-cavery@redhat.com> <20170403121718.GA13130@infradead.org> <58E24A9A.30200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58E24A9A.30200@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2017 at 09:14:02AM -0400, Cathy Avery wrote: > On 04/03/2017 08:17 AM, Christoph Hellwig wrote: > > > if (host->transportt == fc_transport_template) { > > > + struct fc_rport_identifiers ids = { > > > + .roles = FC_PORT_ROLE_FCP_TARGET, > > > + }; > > I don't think storvsc ever acts as FCP target. > > In order to implement the work around so that the scsi scan works indicating > FC_PORT_ROLE_FCP_TARGET as a role was necessary due to its test in > fc_scsi_scan_rport. The idea here is to avoid making any changes to the > fc_transport driver which was of some concern. Please add a FC_PORT_ROLE_FCP_DUMMY_INITIATOR role instead.