From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbdDDJDn (ORCPT ); Tue, 4 Apr 2017 05:03:43 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:45967 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbdDDJDl (ORCPT ); Tue, 4 Apr 2017 05:03:41 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.wolfsonmicro.com Date: Tue, 4 Apr 2017 10:04:10 +0100 From: Charles Keepax To: Tony Lindgren CC: Lee Jones , Samuel Ortiz , , , Marcel Partap , Michael Scott , "Sebastian Reichel" Subject: Re: [PATCH 1/3] mfd: cpcap: Fix interrupt to use level interrupt Message-ID: <20170404090410.GX6986@localhost.localdomain> References: <20170404031556.5093-1-tony@atomide.com> <20170404031556.5093-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170404031556.5093-2-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704040082 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 03, 2017 at 08:15:54PM -0700, Tony Lindgren wrote: > I made a mistake assuming the device tree configuration for interrupt > triggering was somehow passed to the SPI device but it's not. > > In the Motorola Linux kernel tree CPCAP PMIC is configured as a rising > edge triggered interrupt, but then then it's interrupt handler keeps > looping until the GPIO line goes down. So the CPCAP interrupt is clearly > a level interrupt and not an edge interrupt. > > Earlier when I tried to configure it as level interrupt using the > device tree, I did not account that the triggering only gets passed > to the SPI core and it also needs to be specified in the CPCAP driver > when we do devm_regmap_add_irq_chip(). > > Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") > Cc: Charles Keepax > Cc: Marcel Partap > Cc: Michael Scott > Cc: Sebastian Reichel > Signed-off-by: Tony Lindgren > --- Thanks for looking into that further, I thought that might be what was going on. Reviewed-by: Charles Keepax Thanks, Charles