From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: hverkuil@xs4all.nl, mchehab@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: touchscreen: sur40: fix bad endianness handling in sur40_poll
Date: Tue, 4 Apr 2017 10:07:11 -0700 [thread overview]
Message-ID: <20170404170711.GA29558@dtor-ws> (raw)
In-Reply-To: <1491311177-16974-1-git-send-email-martink@posteo.de>
On Tue, Apr 04, 2017 at 03:06:17PM +0200, Martin Kepplinger wrote:
> sparse says:
>
> sur40.c:372:40: warning: restricted __le32 degrades to integer
>
> the header's data is __le32 so we need to convert it before comparing.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
Applied, thank you.
> ---
> drivers/input/touchscreen/sur40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c
> index 4c0eeca..128e5bd 100644
> --- a/drivers/input/touchscreen/sur40.c
> +++ b/drivers/input/touchscreen/sur40.c
> @@ -369,7 +369,7 @@ static void sur40_poll(struct input_polled_dev *polldev)
> * packet ID will usually increase in the middle of a series
> * instead of at the end.
> */
> - if (packet_id != header->packet_id)
> + if (packet_id != le32_to_cpu(header->packet_id))
> dev_dbg(sur40->dev, "packet ID mismatch\n");
>
> packet_blobs = result / sizeof(struct sur40_blob);
> --
> 2.1.4
>
--
Dmitry
prev parent reply other threads:[~2017-04-04 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 13:06 [PATCH] input: touchscreen: sur40: fix bad endianness handling in sur40_poll Martin Kepplinger
2017-04-04 17:07 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404170711.GA29558@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox