From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755039AbdDDR4M (ORCPT ); Tue, 4 Apr 2017 13:56:12 -0400 Received: from mail.us.es ([193.147.175.20]:48618 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754611AbdDDR4K (ORCPT ); Tue, 4 Apr 2017 13:56:10 -0400 Date: Tue, 4 Apr 2017 19:56:00 +0200 From: Pablo Neira Ayuso To: Arushi Singhal Cc: wensong@linux-vs.org, Simon Horman , outreachy-kernel@googlegroups.com, Julian Anastasov , Jozsef Kadlecsik , davem@davemloft.net, netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator Message-ID: <20170404175600.GB1154@salvia> References: <20170329101406.GA29770@arushi-HP-Pavilion-Notebook> <20170404174111.GB7257@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170404174111.GB7257@verge.net.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote: > On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote: > > Replace explicit NULL comparison with ! operator to simplify code. > > > > Signed-off-by: Arushi Singhal > > --- > > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++--- > > net/netfilter/ipvs/ip_vs_proto.c | 8 ++--- > > I count 18 instances of "!= NULL in net/netfilter/ipvs/ip_vs_proto but this > patch only seems to update 8 of them. I would prefer to fix all or none of > them. Agreed. Please address all instances and resubmit.