From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbdDDS3t (ORCPT ); Tue, 4 Apr 2017 14:29:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41806 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668AbdDDS3s (ORCPT ); Tue, 4 Apr 2017 14:29:48 -0400 Date: Tue, 4 Apr 2017 20:29:34 +0200 From: Greg Kroah-Hartman To: Pushkar Jambhlekar Cc: Oleg Drokin , Andreas Dilger , James Simmons , "John L. Hammond" , Al Viro , Lai Siyao , James Nunez , Andrew Perepechko , wang di , Bob Glossman , Andreas Gruenbacher , Jinshan Xiong , Bobi Jam , "Kirill A. Shutemov" , Henri Doreau , Prakash Surya , Emoly Liu , Dmitry Eremin , Johann Lombardi , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] drivers/staging/lustre: Replacing 'unsigned' with 'unsigned int' Message-ID: <20170404182934.GA3697@kroah.com> References: <1491299043-29224-1-git-send-email-pushkar.iit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491299043-29224-1-git-send-email-pushkar.iit@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 04, 2017 at 03:14:03PM +0530, Pushkar Jambhlekar wrote: > Replacing 'unsigned' with 'unsigned int' Why? You need to explain why you do something, not just say what you did (that should be obvious if you read the patch...) thanks, greg k-h