From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755138AbdDDWf7 (ORCPT ); Tue, 4 Apr 2017 18:35:59 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:34955 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920AbdDDWf5 (ORCPT ); Tue, 4 Apr 2017 18:35:57 -0400 Date: Tue, 4 Apr 2017 15:35:54 -0700 From: Brian Norris To: Mike Snitzer Cc: Alasdair Kergon , dm-devel@redhat.com, linux-kernel@vger.kernel.org, Enric Balletbo i Serra Subject: Re: dm: move dm_table_destroy() to same header as dm_table_create() Message-ID: <20170404223552.GA121849@google.com> References: <20170328183102.80620-1-briannorris@chromium.org> <20170328193150.GA21445@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328193150.GA21445@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 03:31:51PM -0400, Mike Snitzer wrote: > On Tue, Mar 28 2017 at 2:31pm -0400, > Brian Norris wrote: > > > If anyone is going to use dm_table_create(), they probably should be > > able to use dm_table_destroy() too. Move the dm_table_destroy() > > definition outside the private header, near dm_table_create() > > > > Signed-off-by: Brian Norris > > Not seeing why we need dm_table_create() exposed. So I think you went > the wrong way with this. Unless you have an actual need, I'd prefer to > see dm_table_create() moved from include/linux/device-mapper.h to > drivers/md/dm.h We've been carrying code in our ChromeOS kernel to parse a cmdline arg for setting up early DM maps -- e.g., a dm-verity rootfs without using an initramfs. We currently use dm_table_create() from init/*.c (and we *should* be using dm_table_destroy() in the error paths). So I'm certainly not going to send the patch to do the reverse :) Enric is working on cleaning up this work to send here, so if you don't want to see this patch now, you may well see it later. Brian